This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Merged
Conversation
Ignores missing signatures in the modules. Ignore that op4 is not used - still include it for completeness. Renames a parameter of the mortal-function to avoid shadowing.
-Wno-subobject-linkage seems only known by GCC. GHC 9.4.2 and later use clang on Windows, so the parameter is useless on Windows.
chord is defined elsewhere. Avoids a warning.
Collaborator
Author
|
CI is failing. Is it related to the change or can we merge? Any clue about the CI error? Do we have an issue to track it? |
Member
|
Thanks! Not sure about the CI error, no issue yet afaik. |
Member
|
(ci error should be fixed on main now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor renames and some ignores of unimportant warnings to get rid of noise when compiling.