-
-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Description
@cb1kenobi This is for the transition from node-appc to node-titanium-sdk!
lib/timodule.js correctly takes into account the version attribute of a <module> tag.
So, <module platform="iphone" version="99.99.99">ti.map</module> in tiapp.xml gives
[DEBUG] Looking for Titanium module id=ti.map version=99.99.99 platform=ios deploy-type=development
[WARN] Could not find a valid Titanium module id=ti.map version=99.99.99 platform=ios deploy-type=development
...
[ERROR] Could not find all required Titanium Modules:
[ERROR] id: ti.map version: 99.99.99 platform: ios deploy-type: development
But lib/tiplugin.js just passes the version attribute:
Lines 132 to 151 in c35e794
| logger && logger.debug(__('Looking for Titanium plugin id=%s version=%s', plugin.id.cyan, originalVersion.cyan)); | |
| let found; | |
| for (let i = 0; !found && i < scopes.length; i++) { | |
| const scope = installed[scopes[i]]; | |
| if (scope && scope[plugin.id]) { | |
| const info = scope[plugin.id][plugin.version] || scope[plugin.id]['unknown'] || scope[plugin.id]['-']; | |
| if (info) { | |
| util.mix(plugin, info); | |
| logger && logger.info(__('Found Titanium plugin id=%s version=%s ', plugin.id.cyan, originalVersion.cyan)); | |
| result.found.push(plugin); | |
| found = true; | |
| } | |
| } | |
| } | |
| if (!found) { | |
| logger && logger.warn(__('Could not find Titanium plugin id=%s version=%s', plugin.id.cyan, originalVersion.cyan)); | |
| result.missing.push(plugin); | |
| } |
So, <plugin version="99.99.99">ti.alloy</plugin> results in following false positive log:
[DEBUG] Detecting plugins in /Users/***/kitchensink-v2/plugins
[DEBUG] Detected plugin: ti.alloy @ /Users/***/kitchensink-v2/plugins/ti.alloy
[DEBUG] Looking for Titanium plugin id=ti.alloy version=99.99.99
[INFO] Found Titanium plugin id=ti.alloy version=99.99.99
The "wrong" plugin version is loaded.
Metadata
Metadata
Assignees
Labels
No labels