Bug fix for generating SQL for logistic XGBoost models#92
Merged
topepo merged 3 commits intotidymodels:masterfrom Feb 4, 2021
Merged
Bug fix for generating SQL for logistic XGBoost models#92topepo merged 3 commits intotidymodels:masterfrom
topepo merged 3 commits intotidymodels:masterfrom
Conversation
topepo
requested changes
Feb 4, 2021
Member
topepo
left a comment
topepo
left a comment
There was a problem hiding this comment.
Can you add a bullet point to the News file about the bug fix?
Author
|
Thanks for the review! I added a News bullet point under the development version, but let me know if you prefer it somewhere else and I can adjust accordingly! |
topepo
approved these changes
Feb 4, 2021
Member
|
Thanks! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54 -- the issue contains a reprex and more detailed explanation. I also added a test that fails on current master and passes on this branch. Thanks for the quick response on the issue and for the useful package!