Add VadlidatingAdmissionPolicy RBAC and bump k8s to v1.30 release#3564
Add VadlidatingAdmissionPolicy RBAC and bump k8s to v1.30 release#3564rene-dekker merged 4 commits intotigera:masterfrom
Conversation
This changeset adds necessary VadlidatingAdmissionPolicy RBACs for Tigera apiserver and bumps k8s dependency to v1.30 release.
|
|
||
| // MetricRelabelConfigs to apply to samples before ingestion. | ||
| MetricRelabelConfigs []*v1.RelabelConfig `json:"metricRelabelings,omitempty"` | ||
| MetricRelabelConfigs []v1.RelabelConfig `json:"metricRelabelings,omitempty"` |
There was a problem hiding this comment.
This is changed in upstream PR #6479. @rene-dekker I think this might be the most clean way to adapt to the vendor change. WDYT?
There was a problem hiding this comment.
We effectively only use this variable in 1 place. I think it would be better to convert the field where it is used, so that we don't need to make breaking changes to our API.
Maybe in pkg/ptr/conversion.go we can add a utility function converting pointer slices to slices using generics?
There was a problem hiding this comment.
Jiawei reminded me that this is not really a breaking change. Everything that is not an array containing nil values should deserialize properly. That paired with the knowledge that this feature is quite new and not used so much yet, makes me think that it is probably ok.
WDYT: @tmjd @caseydavenport
There was a problem hiding this comment.
I think it is OK, but I do also think it is a breaking API change.
For one, anyone importing our code using this field (doubt that's anyone!) will fail to compile when they bump the version.
Technically the nil value array is still a breaking change, although we can probably make a case that nobody is using that config since it wouldn't have worked before anyway (but our API would have accepted it)
All this to say that I'm OK with making this change to make our lives easier, even though technically it's a breaking change.
|
|
||
| func AddPeriodicReconcile(c ctrlruntime.Controller, period time.Duration, handler handler.EventHandler) error { | ||
| return c.Watch(&source.Channel{Source: createPeriodicReconcileChannel(period)}, handler) | ||
| return c.Watch(source.Channel(createPeriodicReconcileChannel(period), handler)) |
There was a problem hiding this comment.
Changed in kubernetes-sigs/controller-runtime#2783.
5 participants
Description
This changeset adds necessary VadlidatingAdmissionPolicy RBACs for Tigera apiserver and bumps k8s dependency to v1.30 release. This change is tested in a Calico Enterprise cluster.
Related to: projectcalico/calico#9335.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.