Skip to content

fix inconsistent store pointers between the region-cache and store-cache (#1826)#1874

Merged
ti-chi-bot[bot] merged 2 commits into
tikv:tidb-8.5from
ti-chi-bot:cherry-pick-1826-to-tidb-8.5
Feb 12, 2026
Merged

fix inconsistent store pointers between the region-cache and store-cache (#1826)#1874
ti-chi-bot[bot] merged 2 commits into
tikv:tidb-8.5from
ti-chi-bot:cherry-pick-1826-to-tidb-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #1826

fix #1823

Summary by CodeRabbit

  • Refactor

    • Store metadata handling made thread-safe; metadata updates now occur in-place and logging/address/type reporting improved.
  • Bug Fixes

    • Address and label changes no longer disrupt replica references or selection stability during restarts and re-resolves.
  • Tests

    • Tests updated and extended to cover address/label updates, restart scenarios, and leader/proxy selection consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

fix tikv#1823

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-tidb-8.5 labels Feb 6, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member Author

@zyguan This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: zyguan <zhongyangguan@gmail.com>
@cfzjywxk cfzjywxk requested a review from zyguan February 6, 2026 07:06
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 6, 2026
@zyguan
Copy link
Copy Markdown
Contributor

zyguan commented Feb 6, 2026

/retest

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 6, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Feb 6, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-06 07:56:21.800631797 +0000 UTC m=+426452.902030513: ☑️ agreed by zyguan.
  • 2026-02-06 08:39:35.921653154 +0000 UTC m=+1952.227510525: ☑️ agreed by cfzjywxk.

@zyguan
Copy link
Copy Markdown
Contributor

zyguan commented Feb 12, 2026

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 4904d08 into tikv:tidb-8.5 Feb 12, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-tidb-8.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants