Skip to content

test: remove go mod replace#1915

Closed
lance6716 wants to merge 1 commit into
tikv:masterfrom
lance6716:remove-replace
Closed

test: remove go mod replace#1915
lance6716 wants to merge 1 commit into
tikv:masterfrom
lance6716:remove-replace

Conversation

@lance6716
Copy link
Copy Markdown
Contributor

@lance6716 lance6716 commented Mar 17, 2026

Seems pingcap/tidb#66065 is merged so we can remove the replace

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to the latest versions to ensure compatibility, stability, and access to upstream improvements.
    • Simplified dependency configuration by removing unused overrides and keeping essential mappings.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copilot AI review requested due to automatic review settings March 17, 2026 06:51
@ti-chi-bot ti-chi-bot Bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Mar 17, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c71383ff-4a4b-430c-82d6-11d84bc1d903

📥 Commits

Reviewing files that changed from the base of the PR and between 602cdf0 and 8fec219.

⛔ Files ignored due to path filters (1)
  • integration_tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • integration_tests/go.mod

📝 Walkthrough

Walkthrough

Updated multiple module dependencies in integration_tests/go.mod including pingcap/errors, pingcap/tidb, and testify versions. Removed two replace directives that previously redirected tidb modules to bufferflies/tidb, while retaining other replace mappings.

Changes

Cohort / File(s) Summary
Dependency Updates
integration_tests/go.mod
Bumped versions for github.com/pingcap/errors, github.com/pingcap/tidb, and github.com/stretchr/testify. Updated indirect dependency github.com/pingcap/tidb/pkg/parser. Removed two replace directives for tidb modules previously pointing to bufferflies/tidb.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

contribution

Suggested reviewers

  • bufferflies
  • zyguan

Poem

🐰 Dependencies dance and versions shift with care,
Old redirects fade into the air,
Fresh modules arrive, aligned and bright,
The integration tests now sprint in flight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test: remove go mod replace' accurately and concisely describes the main change in the pull request: removing the replace directives from the go.mod file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the temporary Go module replace overrides for TiDB in the integration_tests module now that the upstream TiDB changes are merged, and updates the integration test module’s dependency set accordingly.

Changes:

  • Removed replace directives that pointed github.com/pingcap/tidb (and its parser) to the github.com/bufferflies/tidb fork.
  • Updated integration_tests dependencies to newer upstream TiDB + parser versions and refreshed transitive sums.
  • Bumped a few related dependencies (notably github.com/pingcap/errors and github.com/stretchr/testify) as part of the module refresh.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
integration_tests/go.mod Drops TiDB fork replace entries; updates required versions to upstream TiDB and related deps.
integration_tests/go.sum Removes sums for the forked TiDB module; adds/updates sums for upstream TiDB, parser, and updated deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bufferflies
Copy link
Copy Markdown
Contributor

close by #1921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants