test: remove go mod replace#1915
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated multiple module dependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. |
There was a problem hiding this comment.
Pull request overview
Removes the temporary Go module replace overrides for TiDB in the integration_tests module now that the upstream TiDB changes are merged, and updates the integration test module’s dependency set accordingly.
Changes:
- Removed
replacedirectives that pointedgithub.com/pingcap/tidb(and its parser) to thegithub.com/bufferflies/tidbfork. - Updated
integration_testsdependencies to newer upstream TiDB + parser versions and refreshed transitive sums. - Bumped a few related dependencies (notably
github.com/pingcap/errorsandgithub.com/stretchr/testify) as part of the module refresh.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration_tests/go.mod | Drops TiDB fork replace entries; updates required versions to upstream TiDB and related deps. |
| integration_tests/go.sum | Removes sums for the forked TiDB module; adds/updates sums for upstream TiDB, parser, and updated deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
close by #1921 |
Seems pingcap/tidb#66065 is merged so we can remove the
replaceSummary by CodeRabbit