config: change RUScale default value to 1.40#1924
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChanged the default RU v2 TiKV configuration by updating Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: disksing <i@disksing.com>
0f7b57d to
560f17a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@config/client.go`:
- Around line 147-148: DefaultTiKVClient()/UpdateTiKVRUV2FromExecDetailsV2
currently applies DefaultRUV2TiKVConfig (RUScale 1.40) unconditionally to
ExecDetailsV2.RuV2; change this so the new scale is only applied when the TiKV
server advertises the new RU v2 unit or is at/above the minimum version that
introduced it. Concretely, add a version/capability check in
UpdateTiKVRUV2FromExecDetailsV2 (or in DefaultTiKVClient before calling it) that
inspects the server version/capabilities and only calls DefaultRUV2TiKVConfig()
when the server supports the new RU v2 semantics; otherwise preserve legacy
scaling (or skip rescaling). Also add/update the code comment and public docs to
state the minimum TiKV version or capability required for the new RUScale.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekexium, JmPotato, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change the default value of RUScale from 5697.054498 to 1.40.
Summary by CodeRabbit