Skip to content

BackOffer is a mess #574

@iosmanthus

Description

@iosmanthus

Feature Request

Is your feature request related to a problem? Please describe:

Backoffer is an interface that controls the backoff action while a request failed. But now it is acting as a context instead of what it claims.

It contains:

  1. A slow logger. which also contains a trace id.
  2. A cluster-id introduced from [to #556] metrics: attach cluster label to metrics #558

All this stuff should be accessed by a request handler whenever it wants, as a context instead of squeezing them into BackOffer, an interface that has nothing to do with this information.

Describe the feature you'd like:

Create a context interface and attach all these info to its instance.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions