Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 31, 2021

cherry-pick #160 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/161

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/161:release-3.1-61d15408f456

Signed-off-by: birdstorm samuelwyf@hotmail.com

What problem does this PR solve?

There was an un-necessary list copy in groupKeysByRegion api.

What is changed and how it works?

remove it.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@birdstorm birdstorm merged commit cd3ddc1 into tikv:release-3.1 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants