Skip to content

Conversation

@marsishandsome
Copy link
Collaborator

What problem does this PR solve?

pingcap/tispark#2010

oom during calling client.coprocess will cause missing data bug!

What is changed and how it works?

should not set eof = true if oom occures during calling client.coprocess

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/fix-oom-cause-missing-data branch from 1a987b2 to 6347926 Compare April 9, 2021 09:37
@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome requested a review from birdstorm April 9, 2021 09:37
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit 8d6d663 into tikv:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants