improve build scripts #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Collaborator
|
/run-all-tests |
shell.nix
Outdated
| ( | ||
| pkgs.buildFHSUserEnv { | ||
| name = "client-java-shell"; | ||
| targetPkgs = pkgs: with pkgs;[ maven openjdk11 git ]; |
Collaborator
There was a problem hiding this comment.
currently, client-java is compiled with java8.
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Member
Author
|
@marsishandsome PTAL |
Collaborator
|
/run-all-tests |
tisonkun
approved these changes
Jun 7, 2021
Collaborator
|
@tisonkun, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Collaborator
|
/merge |
Collaborator
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
srcipts/proto.shCheck List
Tests