Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 17, 2021

cherry-pick #199 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/200

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/200:release-3.1-c6d7f0478c51

Signed-off-by: birdstorm samuelwyf@hotmail.com

What problem does this PR solve?

Close #187

What is changed and how it works?

Change the check condition for the scan operations to allow empty start key.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

@birdstorm Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0

birdstorm
birdstorm previously approved these changes Jun 17, 2021
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

@ti-srebot merge failed.

@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

@ti-srebot merge failed.

@birdstorm
Copy link
Collaborator

close due to merge failure

@birdstorm birdstorm closed this Jun 17, 2021
@birdstorm birdstorm reopened this Jun 17, 2021
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@birdstorm birdstorm force-pushed the release-3.1-c6d7f0478c51 branch from 3955a12 to abbae48 Compare June 17, 2021 11:08
@birdstorm
Copy link
Collaborator

/run-all-tests

Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit 7f46827 into tikv:release-3.1 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants