Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 22, 2021

cherry-pick #203 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/206

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/206:release-3.1-d29cf0079c27

What problem does this PR solve?

Support grpc-forward for PDClient. When pd servers are partitioned by network problem, we can forward request by other server.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

* forward pd leader

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@birdstorm birdstorm force-pushed the release-3.1-d29cf0079c27 branch from 7b15468 to 85ef5f0 Compare June 23, 2021 07:52
birdstorm
birdstorm previously approved these changes Jun 23, 2021
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

@ti-srebot merge failed.

Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@birdstorm
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@sunxiaoguang
Copy link
Member

@ti-srebot merge failed.

You can try merge master before running tests, I have fixed a lint issue and the issue of test you just fixed.

@birdstorm
Copy link
Collaborator

@ti-srebot merge failed.

You can try merge master before running tests, I have fixed a lint issue and the issue of test you just fixed.

thanks!

Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit c7d9ff1 into tikv:release-3.1 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants