Skip to content

Refactor RawKVClient CAS API #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-srebot merged 2 commits into from
Jun 24, 2021
Merged

Refactor RawKVClient CAS API #213

ti-srebot merged 2 commits into from
Jun 24, 2021

Conversation

@marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Jun 23, 2021 •
edited
Loading

What problem does this PR solve?

close #212

Currently, users should pass the parameter atomic to funcions likeput、batchPut、delete、batchDelete when using CAS in RawKVClient.

What is changed and how it works?

Add a config tikv.enable_atomic_for_cas replacing the atomic parameter on each write function like put、delete.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/refactor-cas branch 2 times, most recently from caa5e5d to eeac001 Compare June 23, 2021 09:37
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 23, 2021

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 23, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/refactor-cas branch 2 times, most recently from 3ecb012 to d2cd027 Compare June 23, 2021 09:46
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 23, 2021

/run-all-tests

@marsishandsome
Refactor RawKVClient CAS API
d0afb12 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 23, 2021

/run-all-tests

birdstorm
birdstorm approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andylokandy
andylokandy approved these changes Jun 23, 2021
View reviewed changes
@marsishandsome
fix test
2a7ef84 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 24, 2021

/run-all-tests

@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 24, 2021

/merge

@ti-srebot
Copy link
Collaborator

ti-srebot commented Jun 24, 2021

/run-all-tests

@ti-srebot ti-srebot merged commit d90237f into tikv:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andylokandy andylokandy andylokandy approved these changes

@birdstorm birdstorm birdstorm approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

Assignees

No one assigned

Labels

status/can-merge status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor CAS interface

4 participants

@marsishandsome @ti-srebot @andylokandy @birdstorm