Skip to content

keep README update (#197) #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birdstorm merged 2 commits into from
Jun 25, 2021
Merged

keep README update (#197) #217

birdstorm merged 2 commits into from
Jun 25, 2021

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 25, 2021 •
edited
Loading

cherry-pick #197 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/217

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/217:release-3.1-7fe64c60e7be

What problem does this PR solve?

close #178

What is changed and how it works?

  • remote Chinese character
  • fix error in code example
  • update version in pom example

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome @ti-srebot
cherry pick tikv#197 to release-3.1
927ca07 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jun 25, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 25, 2021
Merged
@ti-srebot ti-srebot requested a review from birdstorm June 25, 2021 06:48
birdstorm
birdstorm previously approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm self-requested a review June 25, 2021 06:51
@birdstorm birdstorm dismissed their stale review June 25, 2021 06:51

conflicts

@birdstorm
resolve conflicts
a8737a1 
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
birdstorm
birdstorm approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

birdstorm commented Jun 25, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jun 25, 2021

/run-all-tests

@birdstorm birdstorm merged commit 2aa5845 into tikv:release-3.1 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees

@marsishandsome marsishandsome

Labels

status/can-merge status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @birdstorm @marsishandsome