Skip to content

Support metrics with multiple TiSessions with the same port #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-srebot merged 2 commits into from
Jun 29, 2021
Merged

Support metrics with multiple TiSessions with the same port #220

ti-srebot merged 2 commits into from
Jun 29, 2021

Conversation

@marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Jun 29, 2021 •
edited
Loading

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

close #218

Currently, only one TiSession is supported with metrics exporting.

What is changed and how it works?

  • Support metrics with multiple TiSessions with the same port
  • Do not support multiple TiSessions with different ports

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/refactor-metrics branch 5 times, most recently from 327ea24 to 03cd3d0 Compare June 29, 2021 03:31
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 29, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/refactor-metrics branch from 03cd3d0 to 5aa2a04 Compare June 29, 2021 03:43
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 29, 2021

/run-all-tests

@marsishandsome
Support metrics with multiple TiSessions with the same port
5754b9f 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/refactor-metrics branch from 5aa2a04 to 5754b9f Compare June 29, 2021 04:08
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 29, 2021

/run-all-tests

birdstorm
birdstorm approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

@marsishandsome
fix
6cd49a1 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Jun 29, 2021

/merge

@ti-srebot
Copy link
Collaborator

ti-srebot commented Jun 29, 2021

/run-all-tests

@ti-srebot ti-srebot merged commit 630e151 into tikv:master Jun 29, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 29, 2021
@marsishandsome @ti-srebot
cherry pick tikv#220 to release-3.1
d92bada 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 29, 2021
Closed
@ti-srebot
Copy link
Collaborator

ti-srebot commented Jun 29, 2021

cherry pick to release-3.1 in PR #221

marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Jun 29, 2021
@marsishandsome
Support metrics with multiple TiSessions with the same port (tikv#220)
5942d2e 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome mentioned this pull request Jun 29, 2021
Merged
marsishandsome added a commit that referenced this pull request Jun 29, 2021
@marsishandsome
Support metrics with multiple TiSessions with the same port (#220) (#222
8210eaf 
)

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

Assignees

No one assigned

Labels

status/can-merge status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support metrics with multiple TiSessions with the same port

3 participants

@marsishandsome @ti-srebot @birdstorm