Skip to content

Forward request by store (#223) #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birdstorm merged 1 commit into from
Jun 30, 2021
Merged

Forward request by store (#223) #224

birdstorm merged 1 commit into from
Jun 30, 2021

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 30, 2021 •
edited
Loading

cherry-pick #223 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/224

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/224:release-3.1-01898542c5d8

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jun 30, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 30, 2021
Merged
@ti-srebot ti-srebot requested a review from birdstorm June 30, 2021 17:35
birdstorm
birdstorm previously approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm force-pushed the release-3.1-01898542c5d8 branch from e4ba696 to ee13c43 Compare June 30, 2021 21:50
@Little-Wallace @birdstorm
Forward request by store (tikv#223)
c6ff978 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@birdstorm birdstorm force-pushed the release-3.1-01898542c5d8 branch from ee13c43 to c6ff978 Compare June 30, 2021 21:51
@birdstorm
Copy link
Collaborator

birdstorm commented Jun 30, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jun 30, 2021

/run-all-tests

birdstorm
birdstorm approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit 814322e into tikv:release-3.1 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees

@Little-Wallace Little-Wallace

Labels

status/can-merge status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @birdstorm @Little-Wallace