-
Notifications
You must be signed in to change notification settings - Fork 118
Support select replica with rich meta data (#171) #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
birdstorm
merged 2 commits into
tikv:release-3.1
from
ti-srebot:release-3.1-fe6617e3c067
Jun 30, 2021
Merged
Support select replica with rich meta data (#171) #225
birdstorm
merged 2 commits into
tikv:release-3.1
from
ti-srebot:release-3.1-fe6617e3c067
Jun 30, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
Author
|
/run-all-tests |
birdstorm
previously approved these changes
Jun 30, 2021
Collaborator
birdstorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
|
/merge |
Collaborator
Author
|
/run-all-tests |
Collaborator
Author
|
@ti-srebot merge failed. |
Collaborator
|
/merge |
Collaborator
Author
|
/run-all-tests |
Collaborator
Author
|
@ti-srebot merge failed. |
Collaborator
|
/merge |
Collaborator
Author
|
/run-all-tests |
birdstorm
approved these changes
Jun 30, 2021
Collaborator
birdstorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #171 to release-3.1
You can switch your code base to this Pull Request by using git-extras:
# In client-java repo: git pr https://github.com/tikv/client-java/pull/225After apply modifications, you can push your change to this PR via:
Signed-off-by: Xiaoguang Sun sunxiaoguang@zhihu.com
What problem does this PR solve?
Pass in more meta data so ReplicaSelector can make better decision at runtime
What is changed and how it works?
Pass in more meta data so ReplicaSelector can make better decision at runtime
Check List
Tests
Code changes
Side effects
Related changes