Skip to content

Try other peer when current leader of this region is not available. (#232) #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
birdstorm merged 2 commits into from
Jul 18, 2021
Merged

Try other peer when current leader of this region is not available. (#232) #234

birdstorm merged 2 commits into from
Jul 18, 2021

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 15, 2021 •
edited
Loading

cherry-pick #232 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/234

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/234:release-3.1-d4d1c6ac6aa3

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@Little-Wallace @ti-srebot
cherry pick tikv#232 to release-3.1
83a9a94 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jul 15, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jul 15, 2021
Merged
@ti-srebot ti-srebot requested a review from birdstorm July 15, 2021 03:21
birdstorm
birdstorm previously approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

birdstorm commented Jul 15, 2021

/merge

@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jul 15, 2021

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

ti-srebot commented Jul 15, 2021

@ti-srebot merge failed.

@Little-Wallace
Copy link
Contributor

Little-Wallace commented Jul 15, 2021

/run-all-tests

1 similar comment
@Little-Wallace
Copy link
Contributor

Little-Wallace commented Jul 15, 2021

/run-all-tests

@Little-Wallace
Copy link
Contributor

Little-Wallace commented Jul 16, 2021

/run-integration-test

@Little-Wallace
fix bug
ca9eb2e 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@Little-Wallace
Copy link
Contributor

Little-Wallace commented Jul 16, 2021

/run-all-tests

birdstorm
birdstorm approved these changes Jul 18, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm birdstorm merged commit d0b4965 into tikv:release-3.1 Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

Assignees

@Little-Wallace Little-Wallace

Labels

status/can-merge status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @birdstorm @Little-Wallace