Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 28, 2021

cherry-pick #241 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/242

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/242:release-3.1-7fe59efd4aa1

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

marsishandsome
marsishandsome previously approved these changes Jul 28, 2021
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@Little-Wallace
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator

/run-all-tests

Little-Wallace and others added 2 commits July 28, 2021 14:15
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@marsishandsome
Copy link
Collaborator

/run-all-tests

Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
Copy link
Collaborator

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants