Skip to content

bulk load: support deduplicate key #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marsishandsome merged 1 commit into from
Sep 14, 2021
Merged

bulk load: support deduplicate key #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions src/main/java/org/tikv/common/importer/ImporterClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.tikv.common.TiConfiguration;
import org.tikv.common.TiSession;
import org.tikv.common.codec.Codec;
import org.tikv.common.codec.CodecDataOutput;
import org.tikv.common.exception.GrpcException;
import org.tikv.common.exception.TiKVException;
import org.tikv.common.key.Key;
import org.tikv.common.region.TiRegion;
import org.tikv.common.region.TiStore;
Expand All @@ -34,6 +37,8 @@
import org.tikv.kvproto.Metapb;

public class ImporterClient {
private static final Logger logger = LoggerFactory.getLogger(ImporterClient.class);

private TiConfiguration tiConf;
private TiSession tiSession;
private ByteString uuid;
Expand All @@ -42,6 +47,8 @@ public class ImporterClient {
private TiRegion region;
private Long ttl;

private boolean deduplicate = false;

private boolean streamOpened = false;
private ImportSstpb.SSTMeta sstMeta;
private List<ImporterStoreClient> clientList;
Expand All @@ -58,25 +65,45 @@ public ImporterClient(
this.ttl = ttl;
}

public boolean isDeduplicate() {
return deduplicate;
}

public void setDeduplicate(boolean deduplicate) {
this.deduplicate = deduplicate;
}

/**
* write KV pairs to RawKV/Txn using KVStream interface
*
* @param iterator
*/
public void write(Iterator<Pair<ByteString, ByteString>> iterator) throws GrpcException {
public void write(Iterator<Pair<ByteString, ByteString>> iterator) throws TiKVException {

streamOpened = false;

int maxKVBatchSize = tiConf.getImporterMaxKVBatchSize();
int maxKVBatchBytes = tiConf.getImporterMaxKVBatchBytes();
int totalBytes = 0;
ByteString preKey = null;
while (iterator.hasNext()) {
ArrayList<ImportSstpb.Pair> pairs = new ArrayList<>(maxKVBatchSize);
for (int i = 0; i < maxKVBatchSize; i++) {
if (iterator.hasNext()) {
Pair<ByteString, ByteString> pair = iterator.next();
pairs.add(ImportSstpb.Pair.newBuilder().setKey(pair.first).setValue(pair.second).build());
totalBytes += (pair.first.size() + pair.second.size());
if (preKey != null && preKey.equals(pair.first)) {
if (deduplicate) {
logger.info("skip duplicate key: {}", preKey.toStringUtf8());
} else {
throw new TiKVException(
String.format("duplicate key found, key = %s", preKey.toStringUtf8()));
}
} else {
pairs.add(
ImportSstpb.Pair.newBuilder().setKey(pair.first).setValue(pair.second).build());
totalBytes += (pair.first.size() + pair.second.size());
preKey = pair.first;
}
}
if (totalBytes > maxKVBatchBytes || !iterator.hasNext()) {
break;
Expand Down