Skip to content

Conversation

@peng1999
Copy link
Member

@peng1999 peng1999 commented Sep 16, 2021

Signed-off-by: Peng Guanwen pg999w@outlook.com

What problem does this PR solve?

#268 needs to call pause checker in Java client. This PR adds the function.

What is changed and how it works?

Added functions:

  • PDClient.keepPauseChecker
  • PDClient.stopKeepPauseChecker
  • PDClient.resumeChecker

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to be included in the release note

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999 peng1999 marked this pull request as ready for review September 16, 2021 12:27
@peng1999
Copy link
Member Author

/cc @marsishandsome

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this PR after tikv/pd#4092 is merged

@marsishandsome
Copy link
Collaborator

run mvn clean package -DskipTests to format the code

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@marsishandsome
Copy link
Collaborator

/run-all-tests

2 similar comments
@marsishandsome
Copy link
Collaborator

/run-all-tests

@marsishandsome
Copy link
Collaborator

/run-all-tests

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator

/run-all-tests

@peng1999
Copy link
Member Author

/run-all-tests

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
@peng1999
Copy link
Member Author

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator

/run-all-tests

Signed-off-by: Peng Guanwen <pg999w@outlook.com>
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator

/run-all-tests

@marsishandsome marsishandsome merged commit d543ae7 into tikv:master Sep 28, 2021
@mzygQAQ
Copy link

mzygQAQ commented Oct 31, 2024

pause checker is not enough for bulkload, we should also remove pd's schedulers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants