Skip to content

Ingest: add retry with not leader error #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marsishandsome merged 3 commits into from
Sep 17, 2021
Merged

Ingest: add retry with not leader error #278

marsishandsome merged 3 commits into from
Sep 17, 2021

Conversation

@marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Sep 17, 2021 •
edited
Loading

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

tikv/migration#23

leader may change during ingest

What is changed and how it works?

add ingest retry

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/add-ingest-retry-v2 branch 2 times, most recently from 95f4d62 to 0d8e465 Compare September 17, 2021 02:42
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/add-ingest-retry-v2 branch from 0d8e465 to 6fde412 Compare September 17, 2021 02:48
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/add-ingest-retry-v2 branch from 6fde412 to 5573b74 Compare September 17, 2021 03:23
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

@marsishandsome
Ingest: add retry with not leader error
852816e 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/add-ingest-retry-v2 branch from 5573b74 to 852816e Compare September 17, 2021 03:43
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

Little-Wallace
Little-Wallace reviewed Sep 17, 2021
View reviewed changes
Little-Wallace
Little-Wallace reviewed Sep 17, 2021
View reviewed changes
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

@marsishandsome
address codereview
e410d05 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/add-ingest-retry-v2 branch from 7db4abe to e410d05 Compare September 17, 2021 06:00
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

@marsishandsome
address code review
700b5b1 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 17, 2021

/run-all-tests

Little-Wallace
Little-Wallace approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit 786c294 into tikv:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Little-Wallace Little-Wallace Little-Wallace approved these changes

Assignees

No one assigned

Labels

status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsishandsome @Little-Wallace @ti-srebot