Skip to content

support tls #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marsishandsome merged 4 commits into from
Sep 28, 2021
Merged

support tls #280

marsishandsome merged 4 commits into from
Sep 28, 2021
+138 −11

Conversation

@marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Sep 22, 2021

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

#267

What is changed and how it works?

support tls

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/support-tls branch 8 times, most recently from efd68da to a07b873 Compare September 23, 2021 02:56
@marsishandsome
support tls
c0775f7 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 24, 2021

/run-all-tests

andylokandy
andylokandy reviewed Sep 24, 2021
View reviewed changes
@marsishandsome
address code review
d7b60c0 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
kolbe
kolbe reviewed Sep 24, 2021
View reviewed changes
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 27, 2021

/run-all-tests

@marsishandsome
address code review
25501d8 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 27, 2021

/run-all-tests

dveeden
dveeden reviewed Sep 27, 2021
View reviewed changes
Copy link

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we need to do now (or later as follow-up) for:

  • Restricting this to TLSv1.1 or newer?
  • Removing insecure cipher suites (like 3DES)?

@marsishandsome
address code review
df93076 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Sep 28, 2021

/run-all-tests

@marsishandsome marsishandsome merged commit 2838051 into tikv:master Sep 28, 2021
@kolbe kolbe mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andylokandy andylokandy andylokandy approved these changes

+2 more reviewers

@kolbe kolbe kolbe left review comments

@dveeden dveeden dveeden left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marsishandsome @kolbe @dveeden @andylokandy @ti-srebot