Skip to content

Support configuration property file #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marsishandsome merged 1 commit into from
Oct 27, 2021
Merged

Support configuration property file #295

marsishandsome merged 1 commit into from
Oct 27, 2021

Conversation

@marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Oct 27, 2021 •
edited
Loading

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

Support configuration property file

What is changed and how it works?

add parameter tikv.config_file

  • tikv java client config file
  • default: null

This parameter can be passed by -Dtikv.config_file=/path/to/tikv_client_config.properties.

Here is an example of tikv_client_config.properties.

tikv.grpc.timeout_in_ms=150ms 
tikv.grpc.forward_timeout_in_ms=200ms
tikv.metrics.enable=true
tikv.metrics.port=3140

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Oct 27, 2021

/run-all-tests

@marsishandsome
Support configuration property file
ad6a7f4 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Oct 27, 2021

/run-all-tests

Little-Wallace
Little-Wallace approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

birdstorm
birdstorm reviewed Oct 27, 2021
View reviewed changes
birdstorm
birdstorm requested changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as commented

@marsishandsome marsishandsome merged commit 11bd222 into tikv:master Oct 27, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Oct 27, 2021
@marsishandsome @ti-srebot
cherry pick tikv#295 to release-3.1
d516122 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 27, 2021
Merged
@ti-srebot
Copy link
Collaborator

ti-srebot commented Oct 27, 2021

cherry pick to release-3.1 in PR #296

marsishandsome added a commit that referenced this pull request Oct 27, 2021
@ti-srebot @marsishandsome
cherry pick #295 to release-3.1 (#296)
52a101f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

@Little-Wallace Little-Wallace Little-Wallace approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees

No one assigned

Labels

status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marsishandsome @ti-srebot @birdstorm @Little-Wallace