Skip to content

Fix gRPC forward bug when store is unreachable #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marsishandsome merged 3 commits into from
Nov 8, 2021
Merged

Fix gRPC forward bug when store is unreachable #316

marsishandsome merged 3 commits into from
Nov 8, 2021

Conversation

@birdstorm
Copy link
Collaborator

@birdstorm birdstorm commented Nov 5, 2021

  • Fix grpc forward bug.
  • Modify default backoff from 100ms to 20ms.

Little-Wallace and others added 2 commits November 5, 2021 17:41
@Little-Wallace
fix
cc80097 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@birdstorm
modify default backoff settings
cafaf67 
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
marsishandsome
marsishandsome previously approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@birdstorm
format
1e5a177 
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
@marsishandsome
Copy link
Collaborator

marsishandsome commented Nov 8, 2021

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator

marsishandsome commented Nov 8, 2021

/run-all-tests

marsishandsome
marsishandsome approved these changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit d9479b0 into tikv:release-3.1 Nov 8, 2021
@birdstorm birdstorm mentioned this pull request Nov 8, 2021
Closed
@birdstorm birdstorm deleted the forward-3.1-with-backoff branch November 8, 2021 08:28
@marsishandsome marsishandsome mentioned this pull request Dec 1, 2021
Merged
marsishandsome pushed a commit to marsishandsome/client-java that referenced this pull request Dec 1, 2021
@birdstorm @Little-Wallace @marsishandsome
Fix gRPC forward bug when store is unreachable (tikv#316)
ce36fb0 
Signed-off-by: birdstorm <samuelwyf@hotmail.com>

Co-authored-by: Little-Wallace <bupt2013211450@gmail.com>
marsishandsome pushed a commit to marsishandsome/client-java that referenced this pull request Dec 1, 2021
@birdstorm @Little-Wallace @marsishandsome
Fix gRPC forward bug when store is unreachable (tikv#316)
cb8a8b4 
Signed-off-by: birdstorm <samuelwyf@hotmail.com>

Co-authored-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsishandsome marsishandsome marsishandsome approved these changes

Assignees

No one assigned

Labels

status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@birdstorm @marsishandsome @ti-srebot @Little-Wallace