Optimize grpc forward and switch leader logic #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
marsishandsome
changed the title
Collaborator
|
/run-all-tests |
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
zz-jason
reviewed
Nov 18, 2021
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
| boolean exceptionEncountered = pair.second; | ||
| if (peer == null) { | ||
| if (!exceptionEncountered) { | ||
| // all response returned normally, the leader is not elected, just wait until it is ready. |
Member
There was a problem hiding this comment.
will it retry forever if the client is disconnected from all the tikv servers?
Collaborator
Author
There was a problem hiding this comment.
will do in next pr
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
| String.format( | ||
| "leader for region[%d] is not elected, just wait until it is ready", | ||
| region.getId())); | ||
| return true; |
Collaborator
There was a problem hiding this comment.
can we remove this branch?
Collaborator
Author
There was a problem hiding this comment.
will do in next pr
zz-jason
reviewed
Nov 18, 2021
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
zz-jason
reviewed
Nov 18, 2021
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
zz-jason
reviewed
Nov 18, 2021
src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
Member
|
format failed |
Collaborator
Author
|
@zz-jason PTAL |
Collaborator
Author
|
/merge |
Collaborator
|
/run-all-tests |
ti-srebot
approved these changes
Nov 19, 2021
marsishandsome
pushed a commit
to marsishandsome/client-java
that referenced
this pull request
Dec 1, 2021
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.