Skip to content

Use default exporter to register all metrics #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marsishandsome merged 2 commits into from
Nov 19, 2021
Merged

Use default exporter to register all metrics #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77249b0
use defaultexportor
birdstorm Nov 18, 2021
bdfc563
Merge branch 'release-3.1' into use-default-registory
birdstorm Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions src/main/java/org/tikv/common/MetricsServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,10 @@
*/
package org.tikv.common;

import io.prometheus.client.CollectorRegistry;
import io.prometheus.client.exporter.HTTPServer;
import java.net.InetSocketAddress;
import io.prometheus.client.hotspot.DefaultExports;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.tikv.common.policy.RetryPolicy;
import org.tikv.common.region.RegionManager;
import org.tikv.common.region.RegionStoreClient;
import org.tikv.raw.RawKVClient;

public class MetricsServer {
private static final Logger logger = LoggerFactory.getLogger(MetricsServer.class);
Expand All @@ -32,7 +27,6 @@ public class MetricsServer {

private int port;
private HTTPServer server;
private CollectorRegistry collectorRegistry;

public static MetricsServer getInstance(TiConfiguration conf) {
if (!conf.isMetricsEnable()) {
Expand All @@ -58,16 +52,9 @@ public static MetricsServer getInstance(TiConfiguration conf) {

private MetricsServer(int port) {
try {
this.collectorRegistry = new CollectorRegistry();
this.collectorRegistry.register(RawKVClient.RAW_REQUEST_LATENCY);
this.collectorRegistry.register(RawKVClient.RAW_REQUEST_FAILURE);
this.collectorRegistry.register(RawKVClient.RAW_REQUEST_SUCCESS);
this.collectorRegistry.register(RegionStoreClient.GRPC_RAW_REQUEST_LATENCY);
this.collectorRegistry.register(RetryPolicy.GRPC_SINGLE_REQUEST_LATENCY);
this.collectorRegistry.register(RegionManager.GET_REGION_BY_KEY_REQUEST_LATENCY);
this.collectorRegistry.register(PDClient.PD_GET_REGION_BY_KEY_REQUEST_LATENCY);
this.port = port;
this.server = new HTTPServer(new InetSocketAddress(port), this.collectorRegistry, true);
DefaultExports.initialize();
this.server = new HTTPServer(port, true);
logger.info("http server is up " + this.server.getPort());
} catch (Exception e) {
logger.error("http server not up");
Expand Down