Add a flag to determine if TiFlash is enabled #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Member
|
@ankita25 thanks for your contribution! could you please take a look at the checklist in the PR description, remove the unnecessary checks? BTW, please add a unit test for the code. |
Contributor
Author
|
Is it required to deploy tidb cluster locally? All tests seem to be expecting that. |
Collaborator
|
/run-all-tests |
ti-srebot
approved these changes
Nov 30, 2021
Member
|
/merge |
Collaborator
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 9, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.1 in PR #374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TiKV client currently assumes that TiFlash is deployed and starts a threadpool to periodically check tiflash replica status
#350
What is changed and how it works?
Added a boolean flag to determine if tiflash is enabled . The default value is false.
Check List
Tests
Code changes
Side effects
Related changes