check timeout during SeekLeader and SeekProxy #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsishandsome
force-pushed
the
feature/add-backoff-grpc-deadline
branch
from
4cc0eec to
d9c6f51
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/add-backoff-grpc-deadline
branch
from
d9c6f51 to
c5feac8
Compare
Collaborator
Author
|
/run-all-tests |
zz-jason
reviewed
Nov 30, 2021
| this.store = store; | ||
| if (this.store.getProxyStore() != null) { | ||
| this.timeout = conf.getForwardTimeout(); | ||
| } else if (!this.store.isReachable()) { |
Collaborator
Author
There was a problem hiding this comment.
We do not need to do Seek Leader and Seek Proxy during initializing RegionStoreClient. Reasons are:
Seek LeaderandSeek Proxycost time, but we do not want to the initializing process cost too much time.Seek LeaderandSeek Proxywill happen after the first call when reciving gRPC Deadline Exceeded.
zz-jason
reviewed
Nov 30, 2021
Member
|
@marsishandsome please remove the unnecessary items in the PR description. |
marsishandsome
force-pushed
the
feature/add-backoff-grpc-deadline
branch
2 times, most recently
from
c5e485c to
b3ef821
Compare
Collaborator
Author
|
/run-all-tests |
marsishandsome
force-pushed
the
feature/add-backoff-grpc-deadline
branch
from
b3ef821 to
917ee06
Compare
Collaborator
Author
|
/run-all-tests |
marsishandsome
force-pushed
the
feature/add-backoff-grpc-deadline
branch
2 times, most recently
from
afa7c35 to
d015ce4
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/add-backoff-grpc-deadline
branch
from
d015ce4 to
48393a1
Compare
Collaborator
Author
|
/run-all-tests |
ti-srebot
approved these changes
Dec 1, 2021
Member
|
/merge |
Collaborator
|
/run-all-tests |
zz-jason
approved these changes
Dec 1, 2021
Member
|
/merge |
Collaborator
|
/run-all-tests |
marsishandsome
added a commit
to marsishandsome/client-java
that referenced
this pull request
Dec 2, 2021
marsishandsome
added a commit
to marsishandsome/client-java
that referenced
this pull request
Dec 2, 2021
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
added a commit
that referenced
this pull request
Dec 2, 2021
ankita25
pushed a commit
to ankita25/client-java
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
close #353
we should check timeout during SeekLeader and SeekProxy