Fix NullPointerException in getStore #359
Merged
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: birdstorm <samuelwyf@hotmail.com>
zz-jason
reviewed
Dec 3, 2021
| if (resp != null) { | ||
| return resp.getStore(); | ||
| } | ||
| return null; |
Member
There was a problem hiding this comment.
could you add some comments about:
- the possible scenarios where get store fails with a null response
- why not throw an exception in those scenarios
ti-srebot
approved these changes
Dec 4, 2021
Member
|
/merge |
Collaborator
|
/run-all-tests |
Collaborator
|
@birdstorm merge failed. |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.1 in PR #364 |
zz-jason
pushed a commit
that referenced
this pull request
Dec 7, 2021
ankita25
pushed a commit
to ankita25/client-java
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
callWIthRetryreturns a null response,getStorewill throw NullPointerException.