Skip to content

Conversation

@iosmanthus
Copy link
Member

What problem does this PR solve?

This pull request fixes the NPE triggered by the double retry of seekLeaderStore. These buggy lines would also introduce another issue like peer id not match because the meta of the region is not updated.

What is changed and how it works?

Once we change detected a reachable store we need to update the peer information of the region and retry in the most outside code.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Dec 7, 2021

should we wait for #365 to be merged and make a git cherry-pick from that PR?

@iosmanthus
Copy link
Member Author

should we wait for #365 to be merged and make a git cherry-pick from that PR?

No problem

@zz-jason
Copy link
Member

zz-jason commented Dec 9, 2021

close since it's duplicated with #371

@zz-jason zz-jason closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants