Skip to content

[close #370] make gRPC and TiKV health check configurable #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zz-jason merged 7 commits into from
Dec 10, 2021
Merged

[close #370] make gRPC and TiKV health check configurable #369

zz-jason merged 7 commits into from
Dec 10, 2021

Conversation

@humengyu2012
Copy link
Contributor

@humengyu2012 humengyu2012 commented Dec 8, 2021

Fix warning in OLAP engine:

2021-12-08 05:18:47,334 WARN  org.tikv.common.region.StoreHealthyChecker                   [] - store [tikv_host:tikv_port] is not reachable
2021-12-08 05:19:01,130 WARN  org.tikv.common.region.AbstractRegionStoreClient             [] - forward request to store [tikv_host:tikv_port] for region[174126738]
2021-12-08 05:19:01,894 WARN  org.tikv.common.region.StoreHealthyChecker                   [] - store [tikv_host:tikv_port] is not reachable
2021-12-08 05:19:01,933 WARN  org.tikv.common.region.StoreHealthyChecker                   [] - store [tikv_host:tikv_port] recovers to be reachable and canforward
2021-12-08 05:19:05,490 WARN  org.tikv.common.region.StoreHealthyChecker                   [] - store [tikv_host:tikv_port] is not reachable
2021-12-08 05:19:05,604 WARN  org.tikv.common.region.StoreHealthyChecker                   [] - store [tikv_host:tikv_port] recovers to be reachable and canforward

@humengyu2012
Make check health timeout and period Configurable
e1e4927 
Signed-off-by: humengyu <hellohumengyu@gmail.com>
@humengyu2012 humengyu2012 changed the title Make check health timeout and period Configurable to be AP friendly Make check health timeout and period configurable to be AP friendly Dec 8, 2021
zz-jason
zz-jason suggested changes Dec 8, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some tests?

@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 8, 2021

You can have a test to verify default config. In addition, there should be an issue for this PR.

@humengyu2012
add test
79d259c 
Signed-off-by: humengyu <hellohumengyu@gmail.com>
@humengyu2012
add test
368e306 
Signed-off-by: humengyu <hellohumengyu@gmail.com>
@humengyu2012 humengyu2012 mentioned this pull request Dec 9, 2021
Closed
zz-jason
zz-jason approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 9, 2021

/run-all-tests

@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 9, 2021

/merge

@ti-srebot
Copy link
Collaborator

ti-srebot commented Dec 9, 2021

/run-all-tests

@zz-jason zz-jason changed the title Make check health timeout and period configurable to be AP friendly [close #370] make gRPC and TiKV health check configurable Dec 9, 2021
@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 10, 2021

There is a conflicting to be resolved @humengyu2012

@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 10, 2021

/run-all-tests

@humengyu2012
format
60bc572 
Signed-off-by: humengyu <hellohumengyu@gmail.com>
@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 10, 2021

/run-all-tests

@sunxiaoguang
Copy link
Member

sunxiaoguang commented Dec 10, 2021

/merge

@ti-srebot
Copy link
Collaborator

ti-srebot commented Dec 10, 2021

/run-all-tests

@zz-jason zz-jason merged commit 2eb77d6 into tikv:master Dec 10, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 10, 2021
@humengyu2012 @ti-srebot
cherry pick tikv#369 to release-3.1
9d50751 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 10, 2021
Closed
@ti-srebot
Copy link
Collaborator

ti-srebot commented Dec 10, 2021

cherry pick to release-3.1 in PR #387

ankita25 pushed a commit to ankita25/client-java that referenced this pull request Dec 14, 2021
@humengyu2012 @ankita25
[close tikv#370] make gRPC and TiKV health check configurable (tikv#369)
1170503 
Signed-off-by: Ankita Wagh <awagh@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunxiaoguang sunxiaoguang sunxiaoguang approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@zz-jason zz-jason zz-jason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/common status/can-merge status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@humengyu2012 @sunxiaoguang @ti-srebot @zz-jason @birdstorm