Skip to content

[close #375] warm up SmartRawKVClient while creating it #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zz-jason merged 2 commits into from
Dec 9, 2021
Merged

[close #375] warm up SmartRawKVClient while creating it #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861f174
warm up SmartRawKVClient while creating it
iosmanthus Dec 9, 2021
b7a850c
move warm up logic into constructor of SmartRawKVClient
iosmanthus Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/org/tikv/raw/SmartRawKVClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.tikv.common.TiConfiguration;
import org.tikv.common.exception.CircuitBreakerOpenException;
import org.tikv.common.exception.TiKVException;
import org.tikv.common.util.Pair;
import org.tikv.common.util.ScanOption;
import org.tikv.kvproto.Kvrpcpb;
Expand All @@ -33,6 +35,7 @@

public class SmartRawKVClient implements RawKVClientBase {
private static final Logger logger = LoggerFactory.getLogger(SmartRawKVClient.class);
private static final AtomicBoolean warmed = new AtomicBoolean(false);

private static final Histogram REQUEST_LATENCY =
Histogram.build()
Expand Down Expand Up @@ -66,6 +69,15 @@ public class SmartRawKVClient implements RawKVClientBase {
private final CircuitBreaker circuitBreaker;

public SmartRawKVClient(RawKVClientBase client, TiConfiguration conf) {
// Warm up SmartRawKVClient to avoid the first slow call.
if (warmed.compareAndSet(false, true)) {
try {
logger.info("Warming up SmartRawKVClient");
client.get(ByteString.EMPTY);
} catch (final TiKVException ignored) {
}
}

this.client = client;
this.circuitBreaker = new CircuitBreakerImpl(conf);
}
Expand Down