-
Notifications
You must be signed in to change notification settings - Fork 118
[fix #389] move CircuitBreaker to TiSession (#390) #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marsishandsome
merged 5 commits into
tikv:release-3.1
from
ti-srebot:release-3.1-faf1da74bf00
Dec 11, 2021
Merged
[fix #389] move CircuitBreaker to TiSession (#390) #391
marsishandsome
merged 5 commits into
tikv:release-3.1
from
ti-srebot:release-3.1-faf1da74bf00
Dec 11, 2021
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
Author
|
/run-all-tests |
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Collaborator
|
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Collaborator
|
/run-all-tests |
marsishandsome
previously approved these changes
Dec 11, 2021
Collaborator
marsishandsome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
|
/run-all-tests |
marsishandsome
approved these changes
Dec 11, 2021
Collaborator
marsishandsome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #390 to release-3.1
You can switch your code base to this Pull Request by using git-extras:
# In client-java repo: git pr https://github.com/tikv/client-java/pull/391After apply modifications, you can push your change to this PR via:
Signed-off-by: Jian Zhang zjsariel@gmail.com
What problem does this PR solve?
What is changed and how it works?
make CircuitBreaker been created for every TiSession instead of every SmartRawKVClient
Check List
Tests
Related changes