[close #459] use target store context instead of proxy store context when calling grpc forward #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grpc forward Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
changed the title
Collaborator
Author
|
/run-all-tests |
Member
This might need MockTiKV to cover this path, which we don't have now. |
Member
is there another method to add a test without mocktikv? |
Member
|
LGTM |
ti-srebot
approved these changes
Feb 14, 2022
Member
|
/merge |
Collaborator
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Feb 14, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.1 in PR #517 |
zz-jason
pushed a commit
that referenced
this pull request
Feb 15, 2022
Collaborator
Author
|
/run-cherry-picker |
marsishandsome
added a commit
to marsishandsome/client-java
that referenced
this pull request
Feb 15, 2022
marsishandsome
added a commit
to marsishandsome/client-java
that referenced
this pull request
Feb 15, 2022
marsishandsome
added a commit
that referenced
this pull request
Feb 15, 2022
…when calling grpc forward (#458) (#523) Co-authored-by: Jian Zhang <zjsariel@gmail.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com> Signed-off-by: marsishandsome <marsishandsome@gmail.com> Co-authored-by: Jian Zhang <zjsariel@gmail.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
close #459
got StoreNotMatch error when using switchProxyStore
What is changed and how it works?
use target store context instead of proxy store context when calling grpc forward