-
Notifications
You must be signed in to change notification settings - Fork 118
[to #426] add maven site with spotbugs #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
|
@zz-jason PTAL |
zz-jason
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put spotbugs-include.xml in client-java/dev/?
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Done |
zz-jason
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
|
@marsishandsome PTAL |
marsishandsome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/merge |
|
/run-all-tests |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@iosmanthus merge failed. |
|
/merge |
|
/run-all-tests |
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #426
Problem Description:
This pull request adds the maven site plugin and enable spotbugs with it. Here is a demo:

Check List for Tests
This PR has been tested by at least one of the following methods: