[close #435] SimpleDateFormat is not threadsafe #479
Merged
+16
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/run-all-tests |
marsishandsome
force-pushed
the
feature/fix-sloglow-dateformat
branch
from
3c631e2 to
cf81379
Compare
Collaborator
Author
|
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/fix-sloglow-dateformat
branch
from
cf81379 to
057e57c
Compare
Collaborator
Author
|
/run-all-tests |
iosmanthus
approved these changes
Jan 18, 2022
ti-srebot
approved these changes
Jan 18, 2022
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jan 18, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.1 in PR #482 |
marsishandsome
added a commit
that referenced
this pull request
Jan 18, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
close #435
What is changed and how it works?
SimpleDateFormat is not threadsafe.
Use different SimpleDateFormat object for different threads.