-
Notifications
You must be signed in to change notification settings - Fork 118
[to #421] add a python script to analyze slow log stats #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+81
−7
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
87afa5d
[to #421] add a python script to analyze slow log stats
zz-jason 7217fc1
fix license
zz-jason b9f411f
Merge branch 'master' into dev/add-rstats
marsishandsome 4a52494
Merge branch 'master' into dev/add-rstats
zz-jason adb2f51
Merge branch 'master' into dev/add-rstats
zz-jason 41ba8fb
address comment
zz-jason c0260a2
Merge branch 'master' into dev/add-rstats
zz-jason 4f1785c
address comment
zz-jason 794fcaa
Merge branch 'dev/add-rstats' of github.com:zz-jason/client-java into…
zz-jason File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,6 @@ header: | |
| - 'dev/' | ||
| - 'docs/' | ||
| - 'metrics/' | ||
| - 'scripts/' | ||
| - 'LICENSE' | ||
| - 'Makefile' | ||
| - 'pom.xml' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| #!/usr/bin/env python3 | ||
| #!coding:utf-8 | ||
|
|
||
| # Copyright 2022 TiKV Project Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| import re | ||
| import json | ||
| import argparse | ||
|
|
||
| def main(): | ||
| pattern = r'.*SlowLog:.*' | ||
| slowstr = "SlowLog:" | ||
| grpc_pattern = "gRPC tikvpb.Tikv" | ||
| backoff_pattern = "backoff " | ||
|
|
||
| args = parse_args() | ||
| items = [] | ||
| with open(args.slowlog, encoding = 'utf-8') as f: | ||
| for line in f.readlines(): | ||
| matched = re.match(pattern, line, re.M|re.I) | ||
| if matched is not None: | ||
| log = json.loads(line[(line.index(slowstr) + len(slowstr)):]) | ||
| item = { | ||
| 'req': log['func'], | ||
| 'start': log['start'], | ||
| 'tot_lat': latency_ms(log), | ||
| 'tot_grpc': 0, | ||
| 'tot_bo': 0, | ||
| } | ||
| items.append(item) | ||
| for span in log['spans']: | ||
| if grpc_pattern in span['name'] and span['duration'] != 'N/A': | ||
| item['tot_grpc'] += latency_ms(span) | ||
| elif backoff_pattern in span['name'] and span['duration'] != 'N/A': | ||
| item['tot_bo'] += latency_ms(span) | ||
|
|
||
| if args.order == "total": | ||
| items = sorted(items, key=lambda d: d['tot_lat'], reverse=True) | ||
| elif args.order == "grpc": | ||
| items = sorted(items, key=lambda d: d['tot_grpc'], reverse=True) | ||
| elif args.order == "backoff": | ||
| items = sorted(items, key=lambda d: d['tot_bo'], reverse=True) | ||
| else: | ||
| print("unsupported order option, use default value: total") | ||
| items = sorted(items, key=lambda d: d['tot_lat'], reverse=True) | ||
|
|
||
| fmtStr = "{:<12} {:<14} {:<14} {:<20} {:<20}" | ||
| print(fmtStr.format("Request", "Start", "Total Lat(ms)", "Total gRPC Lat(ms)", "Total Backoff Lat(ms)")) | ||
| for item in items: | ||
| print(fmtStr.format(item['req'], item['start'], item['tot_lat'], item['tot_grpc'], item['tot_bo'])) | ||
|
|
||
| def latency_ms(span): | ||
| return int(span['duration'][:len(span['duration'])-2]) | ||
|
|
||
|
|
||
| def parse_args(): | ||
| parser = argparse.ArgumentParser(description="rstats: A TiKV Java Client Request Stats Analyzer") | ||
| parser.add_argument("-o", dest="order", default="total", help="order the output, default: total. accepted value: total, grpc, backoff") | ||
| parser.add_argument("slowlog", help="slow log file") | ||
| return parser.parse_args() | ||
|
|
||
| if __name__ == '__main__': | ||
| main() | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if there is a line containing corrupted JSON?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the script assumes that the slow log file is generated by tikv applications without manual modifications. If it's not a JSON, it means the file is mistakenly modified by someone, the script just not working since it breaks the assumption.