Skip to content

Conversation

@iosmanthus
Copy link
Member

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #415

Problem Description:

SpotBugs doesn't report in pull requests but only pushes to this repository. This commit fix it by enable SpotBugs in pushes to master or pull request to master.

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus
Copy link
Member Author

@zz-jason @marsishandsome PTAL

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #532 (4d4d228) into master (d354ffc) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #532      +/-   ##
============================================
- Coverage     32.12%   32.01%   -0.12%     
+ Complexity     1338     1332       -6     
============================================
  Files           279      279              
  Lines         17372    17372              
  Branches       1980     1980              
============================================
- Hits           5581     5561      -20     
- Misses        11184    11204      +20     
  Partials        607      607              
Impacted Files Coverage Δ
...va/org/tikv/common/region/StoreHealthyChecker.java 51.31% <0.00%> (-13.16%) ⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java 48.65% <0.00%> (-2.94%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.34% <0.00%> (-0.49%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 57.11% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d354ffc...4d4d228. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmanthus
Copy link
Member Author

@marsishandsome PTAL

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit b5b0545 into tikv:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push SpotBugs results as check run annotations

4 participants