[close #540] rawkv: fix scan return empty set while exist empty key (#541) #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
Author
|
/run-all-tests |
Member
|
/merge |
Collaborator
Author
|
/run-all-tests |
Collaborator
Author
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-3.2 #546 +/- ##
==============================================
Coverage ? 30.74%
Complexity ? 1280
==============================================
Files ? 278
Lines ? 17344
Branches ? 1975
==============================================
Hits ? 5333
Misses ? 11434
Partials ? 577 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #541 to release-3.2
You can switch your code base to this Pull Request by using git-extras:
# In client-java repo: git pr https://github.com/tikv/client-java/pull/546After apply modifications, you can push your change to this PR via:
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #540
Problem Description:
This pull request adds an empty key check for
RawScanIterator.hasNext, otherwise, if there is an empty key in TiKV, the scan will always return an empty set.Check List for Tests
This PR has been tested by at least one of the following methods: