Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 28, 2022

cherry-pick #558 to release-3.2
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/580

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/580:release-3.2-6cbf56aede70

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: to #556

Problem Description:

  • code change for client-java
  • code change for grafana panel

Add cluster label for metrics in client-java with the value of cluster id.

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
…e-3.2-6cbf56aede70

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.2@e3e4fe7). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-3.2     #580   +/-   ##
==============================================
  Coverage               ?   31.90%           
  Complexity             ?     1328           
==============================================
  Files                  ?      279           
  Lines                  ?    17462           
  Branches               ?     1981           
==============================================
  Hits                   ?     5572           
  Misses                 ?    11276           
  Partials               ?      614           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e4fe7...6d1fd5c. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason enabled auto-merge (squash) March 28, 2022 11:29
@zz-jason zz-jason merged commit d4ecb2c into tikv:release-3.2 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants