Skip to content

Conversation

@iosmanthus
Copy link
Member

@iosmanthus iosmanthus commented Apr 15, 2022

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #588

Problem Description:

For now, client-java doesn't support TLS cert reloading, this pull request tries to enable this feature on master.

What is changed and how does it work?

Check if the cert files are changed while calling getChannel in ChannelFactory.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick the release branch
  • Need to update the documentation

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #589 (b16d8f5) into master (7fa24c3) will increase coverage by 0.06%.
The diff coverage is 45.94%.

@@             Coverage Diff              @@
##             master     #589      +/-   ##
============================================
+ Coverage     33.87%   33.93%   +0.06%     
- Complexity     1358     1360       +2     
============================================
  Files           270      270              
  Lines         17131    17174      +43     
  Branches       1950     1956       +6     
============================================
+ Hits           5803     5828      +25     
- Misses        10717    10731      +14     
- Partials        611      615       +4     
Impacted Files Coverage Δ
...main/java/org/tikv/common/util/ChannelFactory.java 56.19% <45.94%> (+21.58%) ⬆️
...ty/handler/codec/http2/Http2ConnectionHandler.java 48.16% <0.00%> (-3.92%) ⬇️
...va/org/tikv/common/region/StoreHealthyChecker.java 70.51% <0.00%> (-2.57%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.34% <0.00%> (-0.49%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.68% <0.00%> (-0.44%) ⬇️
...c/main/java/io/grpc/netty/NettyChannelBuilder.java 46.22% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa24c3...b16d8f5. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codev has commented on the uncovered codes in this PR, could you add some tests for it?

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@iosmanthus
Copy link
Member Author

@zz-jason PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 09cb452 into tikv:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TLS cert reload in TiSession

3 participants