-
Notifications
You must be signed in to change notification settings - Fork 118
fix TLS reload doesn't work after delete cert file #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daemonxiao <735462752@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
============================================
+ Coverage 34.60% 34.63% +0.02%
+ Complexity 1418 1416 -2
============================================
Files 278 278
Lines 17342 17352 +10
Branches 1970 1971 +1
============================================
+ Hits 6002 6009 +7
Misses 10732 10732
- Partials 608 611 +3
Continue to review full report at Codecov.
|
1b95aab to
b563b4b
Compare
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
fff2720 to
06111e5
Compare
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.3 in PR #612 |
Signed-off-by: Daemonxiao 735462752@qq.com
What problem does this PR solve?
TiSpark met some problem when use TLS Reload.
Problem Description: tryReload() is used as a task in ScheduledFuture. When tryReload() throws an exception, the schedule will be suppressed which makes tryReload() will not work.
What is changed and how does it work?
Add try-catch in tryReload().
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes