Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 22, 2022

cherry-pick #618 to release-3.3
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/621

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/621:release-3.3-3724e87df6c0

Signed-off-by: Daemonxiao 735462752@qq.com

What problem does this PR solve?

Issue Number: close #619

Because the recycler in ChannelFactory does not set any task when TLS is turned off, the process will get stuck on exit.

What is changed and how does it work?

When we don't use TLS, recycler should be null.

Code changes

  • Has exported function/method change

Side effects

  • NO side effects

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.3@1267187). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-3.3     #621   +/-   ##
==============================================
  Coverage               ?   34.58%           
  Complexity             ?     1419           
==============================================
  Files                  ?      278           
  Lines                  ?    17356           
  Branches               ?     1972           
==============================================
  Hits                   ?     6002           
  Misses                 ?    10748           
  Partials               ?      606           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1267187...7c7cca6. Read the comment docs.

Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmanthus iosmanthus merged commit 7e8bdb0 into tikv:release-3.3 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants