[close #639] reduce lock granularity of RegionStoreClient and PDClient #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
changed the title
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
============================================
- Coverage 35.11% 34.86% -0.26%
+ Complexity 1442 1435 -7
============================================
Files 278 278
Lines 17362 17377 +15
Branches 1974 1974
============================================
- Hits 6097 6058 -39
- Misses 10651 10712 +61
+ Partials 614 607 -7
Continue to review full report at Codecov.
|
iosmanthus
changed the title
iosmanthus
changed the title
xuanyu66
reviewed
Jul 29, 2022
| if (pdClientWrapper != null) { | ||
| if (leaderUrlStr.equals(pdClientWrapper.getLeaderInfo())) { | ||
| @VisibleForTesting | ||
| public boolean trySwitchLeader(String leaderUrlStr) { |
There was a problem hiding this comment.
This method is not Thread-safe, since the value of pdClientWrapper can be changed during statements
xuanyu66
suggested changes
Jul 29, 2022
| // If we have not used follower forward, try the first follower. | ||
| boolean hasReachNextMember = | ||
| pdClientWrapper != null && pdClientWrapper.getStoreAddress().equals(leaderUrlStr); | ||
| pdClientWrapper.get() != null |
| String followerUrlStr = member.getClientUrlsList().get(0); | ||
| followerUrlStr = uriToAddr(addrToUri(followerUrlStr)); | ||
| if (pdClientWrapper != null && pdClientWrapper.getStoreAddress().equals(followerUrlStr)) { | ||
| if (pdClientWrapper.get() != null |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
force-pushed
the
fix-pd-requests-unlimit-timeout
branch
from
88be84c to
743415b
Compare
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
force-pushed
the
fix-pd-requests-unlimit-timeout
branch
from
08de89c to
5c86cbd
Compare
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
force-pushed
the
fix-pd-requests-unlimit-timeout
branch
from
5c86cbd to
d2bf550
Compare
…ests-unlimit-timeout Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
sunxiaoguang
approved these changes
Jul 31, 2022
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jul 31, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.3 in PR #642 |
iosmanthus
added a commit
that referenced
this pull request
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #639
Problem Description:
This pull request tries to reduce the lock granularity of
ReionStoreClientandPDClient, we might block the requests while under a heavy workload.What is changed and how does it work?
Check List for Tests
This PR has been tested by at least one of the following methods:
Related changes