-
Notifications
You must be signed in to change notification settings - Fork 118
[close #663] Select TiFlash Stores Round-Robin #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: shiyuhang <1136742008@qq.com>
595af7d to
5f80236
Compare
Codecov ReportBase: 34.81% // Head: 35.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
============================================
+ Coverage 34.81% 35.06% +0.25%
- Complexity 1433 1446 +13
============================================
Files 278 278
Lines 17377 17380 +3
Branches 1974 1975 +1
============================================
+ Hits 6049 6095 +46
+ Misses 10715 10666 -49
- Partials 613 619 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
|
LGTM |
Signed-off-by: shiyuhang <1136742008@qq.com>
iosmanthus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.3 in PR #688 |
What problem does this PR solve?
Problem Description: client-java always selects the first TiFlash store which may cause read hotspot.
What is changed and how does it work?
Choose the TiFlash stores Round-Robin
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes