Skip to content

Conversation

@shiyuhang0
Copy link
Collaborator

Signed-off-by: shiyuhang 1136742008@qq.com

What problem does this PR solve?

Avoid overflow

Issue Number: close #issue_number

Problem Description: TBD

What is changed and how does it work?

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: shiyuhang <1136742008@qq.com>
@shiyuhang0 shiyuhang0 changed the title [close #663] Avoid negative number [close #663] Avoid overflow Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 35.19% // Head: 35.03% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (c23d725) compared to base (8936a91).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #664      +/-   ##
============================================
- Coverage     35.19%   35.03%   -0.17%     
+ Complexity     1451     1446       -5     
============================================
  Files           278      278              
  Lines         17380    17382       +2     
  Branches       1975     1975              
============================================
- Hits           6117     6089      -28     
- Misses        10647    10686      +39     
+ Partials        616      607       -9     
Impacted Files Coverage Δ
...ain/java/org/tikv/common/region/RegionManager.java 80.00% <100.00%> (+0.26%) ⬆️
...ty/handler/codec/http2/Http2ConnectionHandler.java 51.10% <0.00%> (-3.43%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.34% <0.00%> (-2.93%) ⬇️
src/main/java/io/grpc/netty/NettyClientStream.java 74.07% <0.00%> (-0.75%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 57.11% <0.00%> (-0.65%) ⬇️
...va/org/tikv/common/region/StoreHealthyChecker.java 69.62% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
@ti-srebot
Copy link
Collaborator

@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.

@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Dec 15, 2022
@zhangyangyu zhangyangyu reopened this Dec 15, 2022
@sunxiaoguang
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@sunxiaoguang
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 678
  • 681
  • 678

@zhangyangyu zhangyangyu merged commit 24ed9e2 into tikv:master Dec 20, 2022
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Dec 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator

cherry pick to release-3.3 in PR #689

zhangyangyu pushed a commit that referenced this pull request Dec 20, 2022
shiyuhang0 added a commit to shiyuhang0/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: shiyuhang <1136742008@qq.com>
iosmanthus pushed a commit to iosmanthus/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
shiyuhang0 pushed a commit to shiyuhang0/client-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants