Skip to content

Conversation

@zhangyangyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #issue_number

Problem Description: TBD

What is changed and how does it work?

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 34.92% // Head: 34.87% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7993c78) compared to base (870a9fb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #681      +/-   ##
============================================
- Coverage     34.92%   34.87%   -0.06%     
+ Complexity     1443     1438       -5     
============================================
  Files           278      278              
  Lines         17380    17380              
  Branches       1975     1975              
============================================
- Hits           6070     6061       -9     
- Misses        10696    10706      +10     
+ Partials        614      613       -1     
Impacted Files Coverage Δ
src/main/java/org/tikv/common/region/TiStore.java 56.41% <0.00%> (-5.13%) ⬇️
src/main/java/io/grpc/stub/ClientCalls.java 46.20% <0.00%> (-2.32%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.03% <0.00%> (-1.94%) ⬇️
src/main/java/org/tikv/common/codec/Codec.java 24.26% <0.00%> (+0.32%) ⬆️
src/main/java/org/tikv/raw/RawKVClient.java 76.55% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: zhangyangyu <angwerzx@126.com>
@ti-srebot
Copy link
Collaborator

@shiyuhang0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader.

@zhangyangyu zhangyangyu changed the title Delete stale-checker.yml [close #686] Delete stale-checker.yml Dec 16, 2022
@zhangyangyu zhangyangyu enabled auto-merge (squash) December 16, 2022 04:00
@sunxiaoguang
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 678

@zhangyangyu zhangyangyu disabled auto-merge December 20, 2022 09:11
@zhangyangyu zhangyangyu merged commit 8936a91 into master Dec 20, 2022
@zhangyangyu zhangyangyu deleted the zhangyangyu-patch-1 branch December 20, 2022 09:12
shiyuhang0 pushed a commit to shiyuhang0/client-java that referenced this pull request Dec 20, 2022
Signed-off-by: zhangyangyu <angwerzx@126.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 pushed a commit to shiyuhang0/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: zhangyangyu <angwerzx@126.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
iosmanthus pushed a commit to iosmanthus/client-java that referenced this pull request Dec 30, 2022
Signed-off-by: zhangyangyu <angwerzx@126.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants