-
Notifications
You must be signed in to change notification settings - Fork 118
fix byte array overflow #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@guliangliangatpingcap @birdstorm please help me with review the code |
birdstorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
============================================
+ Coverage 37.93% 37.95% +0.02%
+ Complexity 1610 1609 -1
============================================
Files 278 278
Lines 17482 17482
Branches 1986 1986
============================================
+ Hits 6631 6635 +4
+ Misses 10194 10188 -6
- Partials 657 659 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: wuyj@shuyilink.com
6250e0e to
cd999f9
Compare
|
@birdstorm amend commit information,please review again |
birdstorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Please add a test if it is convenient |
|
Fix DCO please |
|
@shiyuhang0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host |
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host |
|
@ab111404212 could you fix the DCO check? |
|
closed by #728 |

fix byte array overflow when column id greater than 128
What problem does this PR solve?
when use tidb-cdc in flink,if table column size greater than 128 fields,the left field value cant't be read,and is null value,after review related code,i found a bug, when column id greater than 128,colIds is overflow,so binary search can't find correct column id in colIDs array
the detail bug description
apache/flink-cdc#1883